Rename file dialog box in fullscreen & viewer - 2 bugs

Bugs and Issues in 1.82 Test versions which have been fixed and verified as resolved.

Moderators: helmut, XnTriq, xnview

Locked
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Rename file dialog box in fullscreen & viewer - 2 bugs

Post by Dreamer »

1st bug - when I press Tab key it should switch also to extension field, I think. I suggest this order - name>extension>ok>cancel (current order - name>cancel>ok>cancel>ok...).

2nd bug - when I rename file to existing name, it's not renamed and there is no error dialog box, so I could think file is renamed.
User avatar
xnview
Author of XnView
Posts: 46255
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: Rename file dialog box in fullscreen & viewer - 2 bu

Post by xnview »

Dreamer wrote:1st bug - when I press Tab key it should switch also to extension field, I think. I suggest this order - name>extension>ok>cancel (current order - name>cancel>ok>cancel>ok...).

2nd bug - when I rename file to existing name, it's not renamed and there is no error dialog box, so I could think file is renamed.
Ok, i'll check...
Pierre.
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Rename file dialog box in fullscreen & viewer - 2 bu

Post by helmut »

Dreamer wrote:1st bug - when I press Tab key it should switch also to extension field, I think. I suggest this order - name>extension>ok>cancel (current order - name>cancel>ok>cancel>ok...).
Yes, the order you propose is good.
Dreamer wrote:2nd bug - when I rename file to existing name, it's not renamed and there is no error dialog box, so I could think file is renamed.
I think when renaming one file, this is obvious to the user (there's the preview). Why should an error message occur?
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Re: Rename file dialog box in fullscreen & viewer - 2 bu

Post by Dreamer »

helmut wrote:
Dreamer wrote:2nd bug - when I rename file to existing name, it's not renamed and there is no error dialog box, so I could think file is renamed.
I think when renaming one file, this is obvious to the user (there's the preview). Why should an error message occur?
Because when I rename image (in fullscreen) to existing name, I suppose that it's renamed, how could I know that there is another image with the same name in the current folder with e.g. 500 images?
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Rename file dialog box in fullscreen & viewer - 2 bu

Post by helmut »

Dreamer wrote:...
Because when I rename image (in fullscreen) to existing name, I suppose that it's renamed, how could I know that there is another image with the same name in the current folder with e.g. 500 images?
When renaming files, XnView will ensure that no existing file will be overwritten. So I still see no need to display a message message.
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Re: Rename file dialog box in fullscreen & viewer - 2 bu

Post by Dreamer »

helmut wrote:When renaming files, XnView will ensure that no existing file will be overwritten. So I still see no need to display a message message.
But when I rename image, I don't know that it's not renamed, I need to know that I must use another name.

E.g.:

- there are 500 images in folder
- also these images - 001.jpg, 002.jpg, 003.jpg, 004.jpg, 005.jpg and 01.jpg, 02.jpg, 03.jpg, 04.jpg, 05.jpg
- I rename these images in fullscreen - 01.jpg, 02.jpg, 03.jpg, 04.jpg, 05.jpg to 001.jpg, 002.jpg, 003.jpg, 004.jpg, 005.jpg
- I suppose that images have been renamed (since there is no error dialog box) and close xnview

- and imagine that you rename 50 (or more) images like that
- you'd have 50 (or more) images with the "wrong" names
- and now imagine that you burn them to CD

I think it's a quite danger bug, you could sort and rename lot of images even few hours and then you'll see that some images are not renamed - and you don't know what images have the correct names, so you must check all images again...
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: Rename file dialog box in fullscreen & viewer - 2 bu

Post by helmut »

Dreamer wrote:...
I think it's a quite danger bug, you could sort and rename lot of images even few hours and then you'll see that some images are not renamed - and you don't know what images have the correct names, so you must check all images again...
Have you tried out your example? For all I know, XnView will show an error message if files already exist and you will have to change the file template.
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Re: Rename file dialog box in fullscreen & viewer - 2 bu

Post by Dreamer »

helmut wrote:
Dreamer wrote:...
I think it's a quite danger bug, you could sort and rename lot of images even few hours and then you'll see that some images are not renamed - and you don't know what images have the correct names, so you must check all images again...
Have you tried out your example? For all I know, XnView will show an error message if files already exist and you will have to change the file template.
Of course.
Dreamer wrote:Rename file dialog box in fullscreen & viewer - 2 bugs

2nd bug - when I rename file to existing name, it's not renamed and there is no error dialog box, so I could think file is renamed.
Try this:

- create images 1.jpg and 2.jpg (in the same folder)
- try to rename image 2.jpg to 1.jpg in browser
- try to rename image 2.jpg to 1.jpg in viewer

= there is no error dialog box in viewer (and in fullscreen - standard and lite)
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Post by Dreamer »

Fixed. Thanks Pierre. :)
Locked