RC3: Incorrect HTML code

Bugs and Issues in 1.82 Test versions which have been fixed and verified as resolved.

Moderators: helmut, XnTriq, xnview

Locked
ckit
XnThusiast
Posts: 2583
Joined: Tue Feb 17, 2004 1:11 am
Location: QLD, Australia
Contact:

RC3: Incorrect HTML code

Post by ckit »

Using the HTML Validator 0.5.9 extension in Firefox,
I noticed XnView has a incorrect <tr> tag towards the end of the HTML file.
The tag should be a closing tag </tr> not opening tag.

Image
AMD Ryzen 3 3300X 3.8Ghz, 16Gb DDR4, RX6600XT with Dell U2520D at 2560x1440@60Hz scaling 125%
Win11 x64 24H2, Hard Disk Sentinel Pro, MS PowerToys, Process Lasso Pro and Wintoys
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Re: RC2: Incorrect HTML code

Post by helmut »

ckit wrote:Using the HTML Validator 0.5.9 extension in Firefox,
I noticed XnView has a incorrect <tr> tag towards the end of the HTML file.
The tag should be a closing tag </tr> not opening tag.

Image
Good to see that someone actually looked into the HTML generation. Pierre has made real changes in this area and with the right CSS, the pages generated can look really nice.
User avatar
xnview
Author of XnView
Posts: 46255
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: RC2: Incorrect HTML code

Post by xnview »

ckit wrote:Using the HTML Validator 0.5.9 extension in Firefox,
I noticed XnView has a incorrect <tr> tag towards the end of the HTML file.
The tag should be a closing tag </tr> not opening tag.
Ok, i'll fix it
Pierre.
User avatar
ckv
Posts: 786
Joined: Wed Feb 02, 2005 2:30 pm
Location: Glow
Contact:

Post by ckv »

SOLVED

If I get my inspiration back I will try to make nice css set for HTML templates.
XnView Tweak UI - Tool to customize your XnView beyond the regular XnView options.
UI-less Settings - Documentation of all the hidden settings in XnView.
XFAM - Tool to create and customize XnView file associations.
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Post by Dreamer »

ckit, could you confirm it too?
User avatar
ckv
Posts: 786
Joined: Wed Feb 02, 2005 2:30 pm
Location: Glow
Contact:

Post by ckv »

Dreamer wrote:ckit, could you confirm it too?
I runned html pages through HTML tidy now I am sure it's not there anymore

but the doctype is invalid
"Line 1, column 60: invalid formal public identifier "-//w3c//dtd html 4.0 transitional//en": invalid public text class"

should be
<!doctype html public "-//w3c//dtd html 4.0 transitional//en" "http://www.w3.org/TR/REC-html40/loose.dtd">
Theres more of these doctype defins but loose.dtd probably fits just fine for simple page.
XnView Tweak UI - Tool to customize your XnView beyond the regular XnView options.
UI-less Settings - Documentation of all the hidden settings in XnView.
XFAM - Tool to create and customize XnView file associations.
Olive
Posts: 215
Joined: Wed Oct 06, 2004 9:18 pm
Location: Marseille
Contact:

Post by Olive »

ckv wrote:Image
nice icon =)

4.1 strict or xhtml is the way to go...
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Various issues

Post by helmut »

I've just made a check with HTML Tidy which is included in PSPad.

There have been various issues:

== In Template "_Default - Frame"

index.html:
- DOCTYPE should be Frameset//EN.
- Upperlowercase of DOCTYPE
- Empty src="" for frame2 (not solved, yet, think this should point to the first image or a dummy page (another template page).

thumb.html
- DOCType (see above)
- <i>,<h1> were uppercase (minor issue)

page.html
- Misplaced </td>
- <i>,<h1> were uppercase (minor issue)


== In Template "_Default - Frame"
Basically same problems as above.

I have zipped and uploaded the corrected HTML template. The DOCTYPE might be still wrong.
Guest

Post by Guest »

Olive wrote:nice icon =)

4.1 strict or xhtml is the way to go...
Thanks. I made whole set of those. Take a look
If memory serves well strict don't work with frames. (look down :D )
helmut wrote:There have been various issues:

== In Template "_Default - Frame"
I forgot that there are two typy of HTML templates with frames and not frames.
Olive
Posts: 215
Joined: Wed Oct 06, 2004 9:18 pm
Location: Marseille
Contact:

Post by Olive »

So that could be strict for simple and frameset for Frame =)

Code: Select all

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
   "http://www.w3.org/TR/html4/strict.dtd">
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
   "http://www.w3.org/TR/html4/loose.dtd">
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN"
   "http://www.w3.org/TR/html4/frameset.dtd">
ckit
XnThusiast
Posts: 2583
Joined: Tue Feb 17, 2004 1:11 am
Location: QLD, Australia
Contact:

Post by ckit »

My original post has been fixed in RC4.

You can replace the tags <div align="center"> and </div> by using the following code in the CSS file.

table.tabc { border: 0px; margin-left: auto; margin-right: auto; text-align: center }

Now in the HTML file....
<table class="tabc" cellpadding="0" cellspacing="0">

You can also kill "border="0" in the table tags as well.
Also you can choose any class name (I used "tabc")

I'm learning CSS myself at the moment.
Last edited by ckit on Sun Jun 05, 2005 4:19 am, edited 1 time in total.
AMD Ryzen 3 3300X 3.8Ghz, 16Gb DDR4, RX6600XT with Dell U2520D at 2560x1440@60Hz scaling 125%
Win11 x64 24H2, Hard Disk Sentinel Pro, MS PowerToys, Process Lasso Pro and Wintoys
Olive
Posts: 215
Joined: Wed Oct 06, 2004 9:18 pm
Location: Marseille
Contact:

Post by Olive »

i'm not sure border:0; is valid css. Use border:none; or border:0px;

also don't forget to add a meta tag for character encoding
User avatar
Clo
XnThusiast
Posts: 4441
Joined: Sun Oct 17, 2004 4:57 am
Location: Bordeaux, France
Contact:

Right, indeed…

Post by Clo »

:arrow: olive

:) Hello ! Bonsoir,
- That is true… I use CSS for a long while now, even as so "huge" files in some Tutorials / Help folders…

- ckit could give a glance on the help-file of MicroSulphur :

Code: Select all

C:\windows\HELP\HTMLREF.CHM
that you get when installing the (free) HTML Help WorkShop program.

:| It isn't very “fresh” and I couldn't find updates @ M$', but it's a good base.

{ Aside : It's available for you still ! :P }

:mrgreen: Kind regards,
Claude
Clo
Old user ON SELECTIVE STRIKE till further notice
ckit
XnThusiast
Posts: 2583
Joined: Tue Feb 17, 2004 1:11 am
Location: QLD, Australia
Contact:

Post by ckit »

Olive wrote:i'm not sure border:0; is valid css. Use border:none; or border:0px;

also don't forget to add a meta tag for character encoding
Thanks, I really appreciate the help on that.
AMD Ryzen 3 3300X 3.8Ghz, 16Gb DDR4, RX6600XT with Dell U2520D at 2560x1440@60Hz scaling 125%
Win11 x64 24H2, Hard Disk Sentinel Pro, MS PowerToys, Process Lasso Pro and Wintoys
User avatar
helmut
Posts: 8704
Joined: Sun Oct 12, 2003 6:47 pm
Location: Frankfurt, Germany

Post by helmut »

HTML code has been validated by ckv - see separate topic. Closed.
Locked