1.5.0 - settings - toolbar - Set Icon... button has no label when custom command is selected

Older bugs which are supposed to be fixed in 0.84. *** Please try to reproduce your bug and confirm the bug fix. ***

Moderators: XnTriq, helmut, xnview, Dreamer

User avatar
user0
XnThusiast
Posts: 1661
Joined: Sat May 09, 2015 9:37 am

1.5.0 - settings - toolbar - Set Icon... button has no label when custom command is selected

Post by user0 »

XnViewMP 1.5.0 64bit
Windows11 (22H2), display resolution 3840x2160, win scaling 150%


Settings - toolbar
Set Icon... button has no label when custom command is selected

set_icon.png
You do not have the required permissions to view the files attached to this post.
User avatar
xnview
Author of XnView
Posts: 43897
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: 1.5.0 - settings - toolbar - Set Icon... button has no label when custom command is selected

Post by xnview »

:bugconfirmed: Thanks to your detailed description I can reproduce the problem.
Pierre.
User avatar
xnview
Author of XnView
Posts: 43897
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: 1.5.0 - settings - toolbar - Set Icon... button has no label when custom command is selected

Post by xnview »

This problem is supposed to be fixed in XnView MP 1.5.1. Please check and confirm the bug fix here.
Pierre.
User avatar
user0
XnThusiast
Posts: 1661
Joined: Sat May 09, 2015 9:37 am

Re: 1.5.0 - settings - toolbar - Set Icon... button has no label when custom command is selected

Post by user0 »

1.5.1
issue remains

Issue B
1. add new Command button
2. set icon to this button
- press OK
full path will be inserted into its label


Issue C
1. set new icon to default button, eg About
- press OK
icon will be changed
2. goto Settings > Interface > Toolbar
- press Default
icon will revert to default in Settings
- press OK
icon will not revert to default in Toolbar untill restart
User avatar
xnview
Author of XnView
Posts: 43897
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: 1.5.0 - settings - toolbar - Set Icon... button has no label when custom command is selected

Post by xnview »

issue reopened

Issue C: Yes, XnView need to be restarted in this case...
Pierre.
User avatar
user0
XnThusiast
Posts: 1661
Joined: Sat May 09, 2015 9:37 am

Re: 1.5.0 - settings - toolbar - Set Icon... button has no label when custom command is selected

Post by user0 »

xnview wrote: Thu Jul 20, 2023 6:58 am Issue C: Yes, XnView need to be restarted in this case...
it just feels inconsistent as custom icon applies immediately, but its required restart to revert to default
User avatar
xnview
Author of XnView
Posts: 43897
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: 1.5.0 - settings - toolbar - Set Icon... button has no label when custom command is selected

Post by xnview »

This problem is supposed to be fixed in XnView MP 1.5.2. Please check and confirm the bug fix here.
Pierre.
User avatar
user0
XnThusiast
Posts: 1661
Joined: Sat May 09, 2015 9:37 am

Re: 1.5.0 - settings - toolbar - Set Icon... button has no label when custom command is selected

Post by user0 »

152
B - fixed

152-170
Issue D
settings_toolbar_icon_label.png
  • D1 – label positioning
    label horizontal positioning should not depend on icon size
    try to assign test images as icons
    icons_img.zip
  • D2 – 'Set icon...' button label
    'Set icon...' button has no label when custom command is selected (see pic, Riot is selected)


Suggestion
  • rework 'Set icon...' button
    - (done) do not show current icon on this button as it is useless information
    - if custom command already has icon - change button name to 'Remove icon'
You do not have the required permissions to view the files attached to this post.


Last bumped by user0 on Fri Mar 29, 2024 7:53 am.