1.4.5: Viewer - "Lock zoom" and "Fit window to image" options does not work properly

*** Please report new bugs here! ***

Moderators: XnTriq, helmut, xnview, Dreamer

lffs
Posts: 20
Joined: Mon Jun 06, 2022 4:41 pm

1.4.5: Viewer - "Lock zoom" and "Fit window to image" options does not work properly

Post by lffs »

(Re-edited)

XnViewMP 1.4.5 - 64 bit
OS: Windows 10 22H2 64bit
Display Resolution: 2560x1440; scaling 125%

The "Menu: View > Lock zoom" and "Menu: View > Fit window to image" options does not work properly in Viewer mode

Effect:
When Set "Setting: View > View > Auto image size" to "Fit image to window" and enable "Reset 'Auto Image size' Setting with next/previous file",
"Menu: View > Lock zoom": option does not work properly, the image size is automatically resized when navigate to the next image
"Menu: View > Fit window to image": option does not work, the window size does not change.

To reproduce:
1. Set "Setting: View > View > Auto image size" to "Fit image to window" and enable "Reset 'Auto Image size' Setting with next/previous file"
2. a: Open the image in Viewer mode and turn on "Menu: View > Lock zoom" and navigate to the next/previous image.
b: Open the image in Viewer mode and turn on "Menu: View > Fit window to image" and navigate to the next/previous image.


Actual behaviour (bug): When Set "Setting: View > View > Auto image size" to "Fit image to window" and enable "Reset 'Auto Image size' Setting with next/previous file", the "Menu: View > Lock zoom" and "Menu: View > Fit window to image" options does not work properly in Viewer mode.

Expected behaviour:
When Set "Setting: View > View > Auto image size" to "Fit image to window" and enable "Reset 'Auto Image size' Setting with next/previous file",
"Menu: View > Lock zoom" is enabled: the zoom size of the image does not change when navigating to the next/previous image.
"Menu: View > Fit window to image" is enabled: the size of the window changes with the size of the image when navigating to the next/previous image.
User avatar
xnview
Author of XnView
Posts: 43132
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: 1.4.5: Viewer - "Lock zoom" and "Fit window to image" options does not work properly

Post by xnview »

lffs wrote: Thu May 11, 2023 3:41 pm When Set "Setting: View > View > Auto image size" to "Fit image to window" and enable "Reset 'Auto Image size' Setting with next/previous file",
"Menu: View > Lock zoom": option does not work properly, the image size is automatically resized when navigate to the next image
So when opening the image file, 'Fit image to window' should be applied and 'lock zoom' after? And with next/previous, zoom should be kept, right?
"Menu: View > Fit window to image": option does not work, the window size does not change.
It's experimental, so there is issues...
Pierre.
lffs
Posts: 20
Joined: Mon Jun 06, 2022 4:41 pm

Re: 1.4.5: Viewer - "Lock zoom" and "Fit window to image" options does not work properly

Post by lffs »

xnview wrote: Sun May 28, 2023 12:09 pm So when opening the image file, 'Fit image to window' should be applied and 'lock zoom' after? And with next/previous, zoom should be kept, right?
Yes, I think it's reasonable.
User avatar
user0
XnThusiast
Posts: 1377
Joined: Sat May 09, 2015 9:37 am

Re: 1.4.5: Viewer - "Lock zoom" and "Fit window to image" options does not work properly

Post by user0 »

imho "Lock zoom" works as intended - it overcomes all settings and locks current zoom level, nothing to change here.

The only thing I would tweak - how it persists locked zoom level.
Currently it does not and app resets to 100% on app restart, but still keeps "Lock zoom" enabled, I see inconsistancy here.

"Lock zoom" shall be either:
  • persistant (current approach)
    than after app restart - it sould keep zoom level it was locked to
    (more feature-rich approach, but confuses some users who forget "Lock zoom" in enabled state)
  • temporal (session) setting
    after app restart - zoom level resets to last used, with default settings its: "Auto Image size" - "Fit image to window, large only"
I personally have no preferences here, but imho generalized approach shall be (in case settings exist in both places):
- settings - persistant
- menu - temporaly, until restart
lffs
Posts: 20
Joined: Mon Jun 06, 2022 4:41 pm

Re: 1.4.5: Viewer - "Lock zoom" and "Fit window to image" options does not work properly

Post by lffs »

One thing I overlooked:

Is the "Lock zoom" option independent of each tab?

If the "Lock zoom" option is independent of each tab:
If the user saves a session before exiting, the program should be restored to the state before exiting when it starts.
If the user does not save a session (opens a new tab), the "Lock zoom" option should be disabled by default and the zooming should be done using the settings in "Auto image size".

If the "Lock zoom" option is applied globally:
The zoom level of all tabs does not change.
Newly opened tabs are first scaled using the settings in "Auto image size" and then the zoom level is kept unchanged.

I don't think it makes sense to apply it globally, but it is possible to add an option to enable "Lock zoom" in new tabs by default.