0.61: Rating & Colour labels dissappear

*** Please report new bugs here! ***

Moderator: Dreamer

User avatar
xnview
Author of XnView
Posts: 32055
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.61: Rating & Colour labels dissappear

Post by xnview » Thu Nov 07, 2013 3:15 pm

CameronD wrote: If I refresh the DB view after changing rating and colour, then I see the new values in the db table as expected.
When I leave the directory, the db still has the rating/colour.
When I re-enter the folder and refresh the DB the values are zeroed.
Do you have a view tab opened?
Pierre.

CameronD
Posts: 303
Joined: Wed Aug 01, 2007 1:28 pm
Location: Australia

Re: 0.61: Rating & Colour labels dissappear

Post by CameronD » Fri Nov 08, 2013 12:15 am

xnview wrote:Do you have a view tab opened?
I did not have an image view tab opened at any stage of the tests. I just start XnViewMP (in browser mode), browse to the target folder and work on images from the browser's detailed listing.
I think it is the default arrangement of windows: folders, image list, Info and Preview.

I don't think it is the same bug, because I can see the data get written to the DB - it only gets removed when the XnView browser returns to the folder.

CameronD
Posts: 303
Joined: Wed Aug 01, 2007 1:28 pm
Location: Australia

Re: 0.61: Rating & Colour labels dissappear

Post by CameronD » Sat Nov 09, 2013 7:18 am

It looks like some of the previous debugging might be a bit less rigorous than I had hoped.

It seems as if MP refuses to write anything to XnView.db if it is already opened by another program. So the results depend on what order I open the programs.

Also, the previous tests were run with the test folder on a shared samba server, and I discovered that the file modification times include fractional seconds. I don't think these are exposed through the mapped drive interface, but just to be sure I copied the folder to a local drive and reran the tests.

I also renamed my entire ../appdata/roaming/xnviewmp folder so it would reconfigure itself with default options under win-7 x64 and I then removed the default "keep original date/time for saving" option.

After baffling myself for a while with different results depending on program running order I finally settled on running XnViewMP, using sqlite3 command line program to examine the current db state and then exiting.

The results are basically as before - at the time XnViewMP re-opens a folder, the ratings and colours in the db are zeroed, except when the file modification time has been separately updated and there are xmp ratings in the file.

Two instances of XnViewMP can apparently share the db file, but I suppose that is by design.

I'm not sure whether it is significant, but the dates seem to be stored as strings like "20131106 13:12:14", while the sqlite3 ref says the strings should be iso format, with dashes separating year, month and day. That would explain why "sqlite expert" could not interpret the dates. I presume that means xnview is doing all its own date/time calculations.

BloodyRain2k
Posts: 14
Joined: Wed Oct 31, 2012 3:37 pm

Re: 0.61: Rating & Colour labels dissappear

Post by BloodyRain2k » Sun Nov 10, 2013 1:25 am

Just to chime in, I can make my Ratings and Colorings go away with the following procedure which is 100% reproducable for me:

rate or color any amount of images > 141
list by that rating or color, they will be the original amount of images
but now, only the first 141 will actually keep their rating / color, the rest will forget it already when just scrolling down in the browser
list something else and then the used rating / color again and it'll be only the first 141 now

That's with "export rating / color to XMP" off, with that on most will survive the first re-listing, but they will still become less and less the more often I re-list them.
Though now after re-listing a few times even with that on none but the first 141 survive.

It also seems that the loading thread exits prematurely, maybe the loading of one file fails for whatever reason and kills is and with that nuking all others past it too.

Edit: yeah it seems to be the thread crash that's causing the loss, I listed 181 R1's and let it list something else before it reached the breaking point, then re-listed them and it were 181, then I let it reach the breaking point and it were 141 again.
It also doesn't seem to be a certain file, I've tried various combinations of images of more than 250 and I'm always ending up with 141, sometimes I even ended up with less but mosttimes it comes down to 141 survivors.

So my guess without knowing the code so far is that something in the loading thread isn't 100% fail safe and is killing the thread instead of skipping the current image it's trying to load.
Win7 HP x64 - XnViewMP x64

orbspider
Posts: 135
Joined: Tue May 22, 2012 5:42 pm
Location: uk
Contact:

Re: 0.61: Rating & Colour labels dissappear

Post by orbspider » Mon Nov 18, 2013 7:18 am

hi,
glad this bug is being talked about, cos I hit against it couple of weeks back while trying to rate all the pics I upload to web...
and lots of ratings disappeared..

What I do to reproduce:

(I also optimised the db with maintenance)
(No viewer tab open, just one instance of browser)
(export rating and colour label to xml setting is checked)
  • 1. I select 30%-50% of an album's images and rate them 2-star.
    -then I move to another folder and then back to first one, and suddenly over half of the images are no longer rated.
    -Rating remains on images higher up in list, images no.s 1-32

    2. on categories tab, select "xyz" and then press Ctrl-2 and 2-star rate them all.
    -when completes, browse a folder with images with "xyz" and they have no rating.

    3. on categories tab, select the 2-star rating, many images are shown that have no rating star icon over thumbnail!

    4. on categories tab, select "xyz" and then Shift-Ctrl-0 to remove colour labels.
    -browse a folder with images "xyz" and some are still found with a color label.

Then in maintenance I tried dealing with orphaned files/dir's

Which made all files lose their rating, leaving only one folder with rating!

I repeated no.2 above, and then looked at some folders. There were still images with "xyz" category not rated -typically from image no. 33 and down

when I do no. 3 again, only 8000 images, but the "xyz" images number 19000.

If I hadn't catergorized my photos as well as rated them all my *thousands* of uploads selections would now be lost!!
fortunately for me, I learned to do this quite a while back.

I sure hope this can be fixed!

(Linux debian 64bit)

User avatar
xnview
Author of XnView
Posts: 32055
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.61: Rating & Colour labels dissappear

Post by xnview » Mon Dec 02, 2013 2:25 pm

Ok, i can reproduce now. There is 2 bugs.
* Sometimes, rating&color disappear the second time that you browse a folder Issue 167
* Rating&color disappear if we have view mode opened Issue 103
Pierre.

piXuniverse
Posts: 23
Joined: Sat Jul 27, 2013 2:13 pm

Re: 0.61: Rating & Colour labels dissappear

Post by piXuniverse » Mon Dec 02, 2013 3:21 pm

Image

Awesome, awesome news! Thanks!

CameronD
Posts: 303
Joined: Wed Aug 01, 2007 1:28 pm
Location: Australia

Re: 0.61: Rating & Colour labels dissappear

Post by CameronD » Tue Dec 03, 2013 5:10 am

xnview wrote: Sometimes, rating&color disappear the second time that you browse a folder Issue 167
I have tried the new beta version as a 32-bit windows program and can no longer reproduce the problem.

I have noticed a few other gotchas as a result of the testing, and I will bring them up as a separate thread.

tousavelo
Posts: 3
Joined: Fri Jun 08, 2012 5:43 pm

Re: 0.61: Rating & Colour labels dissappear

Post by tousavelo » Sat Dec 28, 2013 6:14 pm

Hi,

Thank you for XnView and XnViewMP. Thank you for the great job on this issue.

Do you have a target release date for the next version, or a suggestion for an older version that would not have that problem ?

Some comments:
* I can access issue 167 in MANTIS but not 103 ?

* I had also a problem with ratings set with XnViewMP 0.61 that had disappeared in XnViewMP 0.61. I could check with iTag and ExifToolGUI that the ratings were still stored in the files as XMP. I deleted the cache for that directory in XnViewMP. The ratings were back in XnViewMP. Yesssss.

* The problem seemed really tricky as some files did retain the rating while others in the same directory has lost it. Congratulations for the great investigation job.

* I didn't try to find a scenario to reproduce the issue but FYI, my typical usage does include filtering based on the rating, and moving files inside XnViewMP (as someone else mentioned).

Thank you again

User avatar
xnview
Author of XnView
Posts: 32055
Joined: Mon Oct 13, 2003 7:31 am
Location: France
Contact:

Re: 0.61: Rating & Colour labels dissappear

Post by xnview » Sun Dec 29, 2013 5:11 pm

tousavelo wrote: Do you have a target release date for the next version, or a suggestion for an older version that would not have that problem ?
Release version will be available very soon
Pierre.

User avatar
GeorgD
Posts: 283
Joined: Thu Oct 12, 2006 2:45 pm

Re: 0.61: Rating & Colour labels dissappear

Post by GeorgD » Sun Jan 12, 2014 4:06 pm

Thanks Pierre! In XnViewMP v0.64 on Win7 64bit, after deleting %appdata%\XnViewMp\*.db I can't reproduce any part of the issue :-) but a minor new one: When opening XnViewMP with a pic shown in full screen, for this image the rating & color label overlay are not shown. When moving to the next image via Page down, overlays are shown, wehen moving back to the firs images, they are also shown => first image does not show overlay => see the separate thread No rating & colour label overlay icon for initial image for that issue.

More details concerning not reproducable parts:
* Before deleting %appdata%\XnViewMp\*.db, for folders that have been indexed by XnViewMP, I don't get an overlay icon for color label & rating in browser and view and info area of view for ALL pictures but only a FEW, but in browser in properties area > XMP tab the label and rating are always shown as expected. This also happens after settings > database > delete all and optimize (long process). For folders, that have never been indexed, everything works fine.
* writing rating & color label works fine in view and also in browse mode when also a view tab is opened
* search finds all images
Last edited by GeorgD on Tue Jan 21, 2014 8:20 pm, edited 3 times in total.
In the XnView Wiki, you can improve the user guide / documentation / F1-help for XnView (classic/Windows) and for XnViewMP

User avatar
m.Th.
XnThusiast
Posts: 1572
Joined: Wed Aug 16, 2006 6:31 am
Contact:

Re: 0.61: Rating & Colour labels dissappear

Post by m.Th. » Mon Jan 13, 2014 7:17 am

GeorgD wrote:Thanks Pierre! In XnViewMP v0.64 on Win7 64bit, after deleting %appdata%\XnViewMp\*.db I can't reproduce any part of the issue :-) but a minor new one: When opening XnViewMP with a pic shown in full screen, for this image the rating & color label overlay are not shown. When moving to the next image via Page down, overlays are shown, wehen moving back to the firs images, they are also shown => first image does not show overlay.

More details concerning not reproducable parts:
* Before deleting %appdata%\XnViewMp\*.db, for folders that have been indexed by XnViewMP, I don't an overlay icon for color label und rating in browser and view and info area of view for ALL pictures but only a FEW, but in browser in properties area > XMP tab the label and rating are always shown as expected. This also happens after settings > database > delete all and optimize (long process). For folders, that have never been indexed, everything works fine.
* writing rating & color label works fine in view and also in browse mode when also a view tab is opened
* search finds alle images
Sorry to say, but IMHO the best thing would be to take out the glitch report in a new, separate thread. Here it will get lost.
m. Th.

The Ascetic Experience - The best photos and texts from Holy Mountain (Athos)

- Dark Themed XnViewMP 0.90 64bit & XnView 2.00 x64 on Win7 x64 -

User avatar
GeorgD
Posts: 283
Joined: Thu Oct 12, 2006 2:45 pm

Re: 0.61: Rating & Colour labels dissappear

Post by GeorgD » Tue Jan 21, 2014 8:19 pm

m.Th. wrote:Sorry to say, but IMHO the best thing would be to take out the glitch report in a new, separate thread. Here it will get lost.
Yes, a separate thread for separate issues makes sense, new post No rating & colour label overlay icon for initial image.
In the XnView Wiki, you can improve the user guide / documentation / F1-help for XnView (classic/Windows) and for XnViewMP

orbspider
Posts: 135
Joined: Tue May 22, 2012 5:42 pm
Location: uk
Contact:

Re: 0.61: Rating & Colour labels dissappear

Post by orbspider » Fri Jan 24, 2014 5:30 am

whoopie! with 0.64 this issue seems to be done away with..

I tested by 1. select a category,
2. select all and press Ctrl-1 to apply rating
3. navigate to any folder with pics with above category

result: pics are rated

also I did 1. rate lots of pics in folder with 100+ files
2. navigate to other folder and back to first

result: pics stay rated even at end of list

good work, thanks Pierre

Post Reply