MP 0.21 Win: "Show tagged files" should be toggle

*** Please report new bugs here! ***

Moderators: XnTriq, helmut, xnview, Dreamer

User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

MP 0.21 Win: "Show tagged files" should be toggle

Post by JohnFredC »

1. Tag a few thumbs
2. Select View->Tag->Show tagged files
3. File list shows only tagged files
4. View->Tag->Show tagged files has no check mark
5. Select View->Tag->Show tagged files
6. Tagged files "only" view remains (i.e., no change)
7. How to return to showing all files?

IMO "Show tagged files" should act as a toggle.

Another approach would be: View->Undo view changes

Edit: The Back arrow (in the mini-toolbar) acts as an "Undo view change", which means its action overloads both navigation AND file visibility... something I don't find immediately intuitive, though it is useful.
John
User avatar
xnview
Author of XnView
Posts: 44920
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by xnview »

Not sure that 'Show tagged files' must be a toggle... It's an action, like when you click on rating or categories. To go back you have 'back' button
Pierre.
User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by JohnFredC »

To go back you have 'back' button
Go "back" where?????

IMO the UI behavior for Tags and Selections is just wrong and MP offers an opportunity to correct it.

Here is another example:

Using 1.97, do the following:
  • 1. Tag a file.
    2. Now, select View->Tag->Invert
The tag is removed from the file and that is all that happens. IMO this is not correct. (or maybe it's a :bug: in 1.97?)

Invert should untag the tagged files and tag the untagged files in the current view.
John
User avatar
xnview
Author of XnView
Posts: 44920
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by xnview »

JohnFredC wrote:
To go back you have 'back' button
Go "back" where?????
The 'Previous' button in mini toolbar
  • 1. Tag a file.
    2. Now, select View->Tag->Invert
The tag is removed from the file and that is all that happens. IMO this is not correct. (or maybe it's a :bug: in 1.97?)

Invert should untag the tagged files and tag the untagged files in the current view.
Tag>Invert tag or untag selected files, you have not this behaviour
Pierre.
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by Dreamer »

xnview wrote:The 'Previous' button in mini toolbar
I know about it, but I agree, this is very important. Currently this is the only (and a bit hidden) way to show previously shown path. If there is an option to show tagged files, there should be also option to disable this option. "toggle" would be probably the easiest way to solve this problem, but perhaps not the best. I think we need a discussion for this.
xnview wrote:Tag>Invert tag or untag selected files, you have not this behaviour
Yes, selected files, it might be confusing for file manager users...
Dreamer
User avatar
xnview
Author of XnView
Posts: 44920
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by xnview »

Dreamer wrote:
xnview wrote:Tag>Invert tag or untag selected files, you have not this behaviour
Yes, selected files, it might be confusing for file manager users...
You would like that 'invert' works on all files and not only selected files??
Pierre.
User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by JohnFredC »

You would like that 'invert' works on all files and not only selected files??
Yes! But what are "all files"? See caveat, below.

My unconscious expectation as a Windows user would be:

The scope of the Invert action should be entire view, that is: all files visible in the file panel.

Selection Example:
  • Before Invert Selection
    • 10 files in view
      1 Selected file
      9 UnSelected Files
  • After Invert Selection
    • 10 files in view
      9 Selected files
      1 UnSelected File
Tag Example:
  • Before Invert Tags
    • 10 files in view
      1 Tagged file
      9 UnTagged Files
    After Invert Tags
    • 10 files in view
      9 Tagged files
      1 UnTagged File
Caveat

But here is an ambiguous scenario:
  • - Filter is set to All
    - User tags a jpg file
    - User changes Filter to Videos
    - Question: Is the jpg still tagged? Answer: YES!
    - User tags a video file
    - User issues Invert Tags
    - What should happen???????
It is bad to complicate the UI unnecessarily, but in this case a detailed tag/selection status dialog should appear with some options the user can select.
Last edited by JohnFredC on Thu Nov 19, 2009 3:24 pm, edited 1 time in total.
John
User avatar
oops66
XnThusiast
Posts: 2005
Joined: Tue Jul 17, 2007 1:17 am
Location: France

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by oops66 »

xnview wrote:...You would like that 'invert' works on all files and not only selected files??
Sorry, No, leave the default 'invert' behavior as it is (only for the selected file) but rename it to "invert current" tag, and add a new command: 'multiple invert selection tag' with an additional menu items.
In fact, I would like to have the same behavior & menu items & shortcuts structure for the functions Select and Tag. If not, it will be always confusing.
Last edited by oops66 on Fri Nov 20, 2009 1:54 pm, edited 3 times in total.
XnViewMP Linux X64 - Debian - X64
Dreamer
XnThusiast
Posts: 4608
Joined: Sun Jul 25, 2004 9:08 pm

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by Dreamer »

xnview wrote:You would like that 'invert' works on all files and not only selected files??
Currently Space/Insert works good for me (in Win version, in MP it should be changed too, also Ctrl+A behavior). It's not so easy, same behavior than in file managers is not possible, in XnView we have "selected" and "tagged" files and it's possible only to select more files with Shift+arrows, so to tag 30 files, now I'd just press Shift+Down arrow few times and Space, but if all files would be used, the only way to select these files would be to manually press Space, right arrow, Space right arrow... or select the files with mouse, but this is not so easy either.

I think it shouldn't be changed now. It should be added as option in menu and then it should be available also as customizable keyboard shortcut, current behavior should be default. Also Shift+arrows should be customizable - select / tag.
Dreamer
User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by JohnFredC »

2Dreamer...

I agree with you. The requested new invert behavior should be "parallel"... implemented as additional commands and additional menu items.

Perhaps:
  • Tag single file: cmd_TagSingleFile
    Tag selection: cmd_TagSelection

    Untag single file: cmd_UnTagSingleFile
    Untag Selection: cmd_UnTagSelection

    Invert Tagging: cmd_InvertTags
What do you think?
John
User avatar
oops66
XnThusiast
Posts: 2005
Joined: Tue Jul 17, 2007 1:17 am
Location: France

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by oops66 »

JohnFredC wrote:2Dreamer...
I agree with you. The requested new invert behavior should be "parallel"... implemented as additional commands and additional menu items.
I agree too.
In fact, XnView needs to have the same behavior & same menu items & same shortcuts structure for the functions Select and Tag. If not, it will be always confusing.
XnViewMP Linux X64 - Debian - X64
User avatar
xnview
Author of XnView
Posts: 44920
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by xnview »

JohnFredC wrote: Tag selection: cmd_TagSelection
Untag Selection: cmd_UnTagSelection
Better than 'Tag current'/'Untag current'
Invert Tagging: cmd_InvertTags
To invert tag of selection?
Pierre.
User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by JohnFredC »

Invert Tagging: cmd_InvertTags
To invert tag of selection?
No.

cmd_InvertTag: Invert/reverse the tagged status of every item in the view, whether selected or not!
  • Tagged items -> untagged
    Untagged items -> tagged


Again, if there is ambiguity, then XnView could ask the user what to do. But IMO, "Invert Tags" should always refer to the tag status of items in (and only in) the current view, regardless of the selection status of the items in the view.
John
User avatar
xnview
Author of XnView
Posts: 44920
Joined: Mon Oct 13, 2003 7:31 am
Location: France

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by xnview »

So you would like to have:
(works on view)
Tag
Untag
Invert
(works on selection)
Tag selection
Untag selection

Right?

'Select All' will be changed to be like Xn 1.97, but 'Tag' must work like it?
1 tagged file => All files tagged
No file tagged=> All files tagged
All files tagged => no file tagged
?
Pierre.
User avatar
JohnFredC
XnThusiast
Posts: 2010
Joined: Wed Mar 17, 2004 8:33 pm
Location: Sarasota Florida

Re: MP 0.21 Win: "Show tagged files" should be toggle

Post by JohnFredC »

Hi Pierre...
'Select All' will be changed to be like Xn 1.97, but 'Tag' must work like it?
1 tagged file => All files tagged
No file tagged=> All files tagged
All files tagged => no file tagged
?
Space bar behavior should not change. It works properly.
So you would like to have:
(works on view)
Tag
Untag
Invert
(works on selection)
Tag selection
Untag selection

Right?
I conceive (someday, at least) of an XnView "Marking" menu. Here are the functions I'd include in such a menu. Perhaps some of them can be implemented soon. Consistent terminology is important.

The ones from your question are highlighted in red.


Mark
  • Selection
    • Select All
      Select None
      ----
      Select tagged
      Unselect tagged
      ----
      Select special
      • Select Group: like current file extension
        Select all (same path)
        Select custom...
      Unselect special
      • Unselect group: like current file extension
        Unselect all (same path)
        Unselect custom...
      ----
      Invert Selection
      ----
      [x] Show only selected files
    ----
    Tag
    • Tag current file {Spacebar}
      Untag current file {Spacebar}

      ----
      Tag all
      Untag all
      ----
      Tag selection
      Untag selection

      ----
      Tag special
      • Tag group: like current file extension
        Tag all (same path)
        Tag custom...
      Untag special
      • Untag group: like current file extension
        Untag all (same path)
        Untag custom...
      ----
      Invert tags
      ----
      Show/Hide tagged files
      [ ] Show only tagged files
      ----
      Tag options:
      • [x] Show/hide tag box
        ----
        ( ) Persist tags always
        ( ) Persist tags this folder
        ( ) Persist tags this view
        (o) Never persist tags
    John